Bug 252679

Summary: [CMake] Rework decision to enable -gsplit-dwarf by default
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, mcatanzaro, philn
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=251685

Description Michael Catanzaro 2023-02-21 10:53:55 PST 
Let's follow this rule: if build type is Debug or RelWithDebInfo, then be helpful and enable debug fission automatically so that we have optimal defaults for developers. But if build type is anything else, then the user must be adding -g manually for debug fission to be useful. If user is manually editing compiler flags, trust that the user knows best and will add -gsplit-dwarf is desired to avoid breaking distro debuginfo systems.

You can also use -DDEBUG_FISSION=ON/OFF to override WebKit's defaults if this guesses wrong, and I almost went with this solution downstream, but (a) this will probably confuse lots of distros or result in broken debuginfo generation, and (b) it's also just nicer to simplify the CMake file.
Comment 1 Michael Catanzaro 2023-02-21 10:59:26 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10458
Comment 2 EWS 2023-02-24 14:24:41 PST 
Committed 260818@main (fe4fdc28cd21): <https://commits.webkit.org/260818@main>

Reviewed commits have been landed. Closing PR #10458 and removing active labels.