Bug 252683
| Summary: | [WPE] Turn off ENABLE_OPENTYPE_MATH | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WPE WebKit | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, fred.wang, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=252682 | ||
Michael Catanzaro
ENABLE_OPENTYPE_MATH is confusing. There are two implementations for parsing the OpenType MATH table:
* WebKit internal implementation, used by WPE, Apple, Windows ports
* harfbuzz implementation, added in 181910@main, used by GTK
I doubt there's any good reason for WPE and GTK ports to be different, so WPE should probably use harfbuzz?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/10461
Frédéric Wang (:fredw)
Yes, on ports where HarfBuzz is available we should use HarfBuzz's implementation.
EWS
Committed 260641@main (0880ca8024e1): <https://commits.webkit.org/260641@main>
Reviewed commits have been landed. Closing PR #10461 and removing active labels.