Bug 252834
| Summary: | Don't let intrinsic padding skew pagination struts on table cells | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tables | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another one where were were failing test case:
Test Case - https://jsfiddle.net/n9fuxpch/show
Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/eacb4f4eb2e61cc6febe80fe23eb44eba2bde8e8
^ We don't match with Expected of this result while Chrome Canary 112 does.
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderTableRow.cpp#151
____
clearIntrinsicPadding();
but I am not sure about 'CellChildrenNeedLayout' but just wanted to raise so we can track this failure.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106148471>
Ahmad Saleem
Figured out:
if (cell->cellWidthChanged())
cell->clearIntrinsicPadding();
____
It leads to Safari match print output in following with Chrome Canary 112 but seems to be broken behavior IMO:
Test Case - https://jsfiddle.net/m0vwngk2/show
Do we need to fix this? Would appreciate any input. Thanks!
Ahmad Saleem
PR attempt - https://github.com/WebKit/WebKit/pull/12391
Test Locally on WebKit TOT - now it passes both test, might do PR again.