Bug 252975

Summary: [margin-trim] shouldChildInlineMarginContributeToContainerIntrinsicSize should take into consideration text
Product: WebKit Reporter: Sammy Gill <sgill26>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase none

Description Sammy Gill 2023-02-26 21:13:08 PST
Created attachment 465194 [details]
Testcase

The attached test case shows how text can end up in a RenderBlockFlow. Currently shouldChildInlineMarginContributeToContainerIntrinsicSize is unable to handle such a case since it takes a RenderElement
Comment 1 Radar WebKit Bug Importer 2023-03-05 21:14:15 PST
<rdar://problem/106271482>
Comment 2 Sammy Gill 2023-03-06 09:45:46 PST
There better option here was to maintain the function signature as is since it makes more sense and then check the value we are trying to pass in at the call site.

*** This bug has been marked as a duplicate of bug 253165 ***