Bug 253141
| Summary: | [CMake] Wayland scanner uses deprecated "code" parameter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Minor | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
Adrian Perez
When building the WPE port, the following warnings are shown by wayland-scanner:
[1874/12858] Generating ../../../WPEToolingBackends/DerivedSources/xdg-shell-protocol.c
Using "code" is deprecated - use private-code or public-code.
See the help page for details.
[1875/12858] Generating ../../../WPEToolingBackends/DerivedSources/xdg-shell-unstable-v6-protocol.c
Using "code" is deprecated - use private-code or public-code.
See the help page for details.
These warnings were introduced in Wayland 1.15.0, we should be using "private-code"
instead (like the GTK port does). Debian 10 has version 1.17, and Ubuntu 20.04 LTS
has version 1.20; therefore we can require version >=1.15—no need for using one
parameter or the other depending on the version.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
The requirement by both the GTK and WPE ports is currently:
find_package(Wayland REQUIRED)
find_package(WaylandProtocols 1.12 REQUIRED)
Let's take advantage of this issue to bump the requirement to 1.15 :)
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/10852
EWS
Committed 261001@main (05993ae119d4): <https://commits.webkit.org/261001@main>
Reviewed commits have been landed. Closing PR #10852 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/106083063>