Bug 253153

Summary:	REGRESSION (260935@main): [ macOS wk2 ] Caught exception: undefined is not an object (evaluating 'element.addEventListener')
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	achristensen, cdumez, gavin.p, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Karl Rackler 2023-03-01 07:10:15 PST

Description:
media/media-source/media-source-webm-append-buffer-after-abort.html
media/media-source/media-source-webm-init-inside-segment.html
media/media-source/media-source-webm.html

media/media-source/media-source-webm tests have two consistent failures and one flaky failure on wk2 after 260935@main. 

The first failure I saw on the dashboard was on 2/28/2023 at 260935@main.

Test run:
https://build.webkit.org/#/builders/708/builds/1505

Results: 
https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/260938@main%20(1505)/results.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=media%2Fmedia-source%2Fmedia-source-webm-append-buffer-after-abort.html&test=media%2Fmedia-source%2Fmedia-source-webm-init-inside-segment.html&test=media%2Fmedia-source%2Fmedia-source-webm.html&platform=mac

Diff:
https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/260938@main%20(1505)/media/media-source/media-source-webm-append-buffer-after-abort-pretty-diff.html
https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/260938@main%20(1505)/media/media-source/media-source-webm-append-buffer-after-abort-pretty-diff.html

--- /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/media/media-source/media-source-webm-append-buffer-after-abort-expected.txt
+++ /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/media/media-source/media-source-webm-append-buffer-after-abort-actual.txt
@@ -4,12 +4,11 @@
 EVENT(sourceopen)
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
+NotSupportedError: The operation is not supported.
 RUN(sourceBuffer.abort())
+TypeError: undefined is not an object (evaluating 'sourceBuffer.abort')
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
-EVENT(canplaythrough)
+TypeError: undefined is not an object (evaluating 'sourceBuffer.appendBuffer')
+Caught exception: "TypeError: undefined is not an object (evaluating 'element.addEventListener')" FAIL
 END OF TEST
 
https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/260938@main%20(1505)/media/media-source/media-source-webm-init-inside-segment-diff.txt
https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/260938@main%20(1505)/media/media-source/media-source-webm-init-inside-segment-pretty-diff.html

--- /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-expected.txt
+++ /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-actual.txt
@@ -4,16 +4,9 @@
 EVENT(sourceopen)
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
+NotSupportedError: The operation is not supported.
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
-Append a new Initialization Segment.
-RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(1)))
-EVENT(update)
+TypeError: undefined is not an object (evaluating 'sourceBuffer.appendBuffer')
+Caught exception: "TypeError: undefined is not an object (evaluating 'element.addEventListener')" FAIL
 END OF TEST
 

https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/260938@main%20(1505)/media/media-source/media-source-webm-diff.txt
https://build.webkit.org/results/Apple-Ventura-Release-WK2-Tests/260938@main%20(1505)/media/media-source/media-source-webm-pretty-diff.html

--- /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/media/media-source/media-source-webm-expected.txt
+++ /Volumes/Data/worker/Apple-Ventura-Release-WK2-Tests/build/layout-test-results/media/media-source/media-source-webm-actual.txt
@@ -4,13 +4,9 @@
 EVENT(sourceopen)
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
+NotSupportedError: The operation is not supported.
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-EXPECTED (resizeEventFired == 'true') OK
-EXPECTED ((videoWidth == 320 || videoWidth == 0) == 'true') OK
-EXPECTED ((videoHeight == 240 || videoHeight == 0) == 'true') OK
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
+TypeError: undefined is not an object (evaluating 'sourceBuffer.appendBuffer')
+Caught exception: "TypeError: undefined is not an object (evaluating 'element.addEventListener')" FAIL
 END OF TEST

Comment 1 Radar WebKit Bug Importer 2023-03-01 07:10:53 PST

<rdar://problem/106085448>

Comment 2 Karl Rackler 2023-03-01 07:23:16 PST

I have marked these tests as a failure while this issue is investigated.

Comment 3 EWS 2023-03-01 07:26:22 PST

Test gardening commit 261007@main (3bec7ba2cd59): <https://commits.webkit.org/261007@main>

Reviewed commits have been landed. Closing PR #10866 and removing active labels.

Comment 4 Ryan Haddad 2023-03-06 10:39:29 PST

A fix attempt was made in https://bugs.webkit.org/show_bug.cgi?id=253184, but the tests are still failing.

Gavin, would you please take another look?

Comment 5 Gavin 2023-03-06 10:44:53 PST

looking

Comment 6 Chris Dumez 2023-03-14 10:49:22 PDT

https://commits.webkit.org/261520@main

Comment 7 Karl Rackler 2023-03-15 11:47:13 PDT

I verified after landing https://commits.webkit.org/261520@main the following:

media/media-source/media-source-webm-append-buffer-after-abort.html is no longer consistently failing.  There are a few flaky failures.

media/media-source/media-source-webm-init-inside-segment.html is consistently passing.

media/media-source/media-source-webm.html is consistently passing on wk2, but still consistently failing on wk1.

Comment 8 Karl Rackler 2023-06-30 08:49:53 PDT

Verified the following:
media/media-source/media-source-webm-append-buffer-after-abort.html is consistently passing
media/media-source/media-source-webm-init-inside-segment.html is consistently passing.
media/media-source/media-source-webm.html  consistently passed on macOS wk2, but consistently fails on wk1.  Test expectations in place for wk1.