Bug 253164

Summary:	REGRESSION(254273@main): wptserve causes "accept incoming network connections?" prompt
Product:	WebKit	Reporter:	Sam Sneddon [:gsnedders] <gsnedders>
Component:	Tools / Tests	Assignee:	Sam Sneddon [:gsnedders] <gsnedders>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, pgriffis, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Sam Sneddon [:gsnedders] 2023-03-01 09:23:10 PST

As of the past ~while, run-webkit-tests triggers a bunch of prompts like:

> Do you want the application "Python.app" to accept incoming network connections?
>
> Clicking Deny may limit the application's behavior. This setting can be changed in the Firewall pane of Network Settings.

This is caused by wptserve not binding properly to localhost, which wouldn't cause these prompts to occur.

Comment 1 Radar WebKit Bug Importer 2023-03-01 09:23:22 PST

<rdar://problem/106090605>

Comment 2 Sam Sneddon [:gsnedders] 2023-03-30 08:39:06 PDT

Oh! This is probably caused by https://github.com/web-platform-tests/wpt/commit/24da741d3c5bba4110f590c1faf771596d543482 (me, 2018), and then at some point later the aliasing was removed.

Comment 3 Sam Sneddon [:gsnedders] 2023-03-30 08:49:33 PDT

Hmm, no: the aliasing is still there.

Comment 4 Sam Sneddon [:gsnedders] 2023-03-30 08:57:58 PDT

Ah: https://github.com/WebKit/WebKit/commit/a5f5fb99a72b67a94407f34c4ab2b76b5bbcbc04#diff-2a84c466417fda744dd91db26cacfdab891060322040874333ad0f2d6314eea7 changed the config:

- "bind_hostname": true,
+ "bind_address": false,

Patrick: I'm not sure why this is needed, especially given Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py also now creates a config with the right set of hosts?

Comment 5 Sam Sneddon [:gsnedders] 2023-03-31 09:34:14 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12241

Comment 6 EWS 2023-04-11 04:26:58 PDT

Committed 262821@main (67e2dc7878b6): <https://commits.webkit.org/262821@main>

Reviewed commits have been landed. Closing PR #12241 and removing active labels.