Bug 253203

Summary:	Get rid of unnecessary layouts on body elements with quirky children
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-03-01 16:16:26 PST

Hi Team,

While going through Blink's commit, I came across another potential merge:

Blink Commit - https://src.chromium.org/viewvc/blink?revision=169269&view=revision

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.cpp#1497

Just wanted to raise so we can fix this.

-webkit-margin-before is still 1.83% on website loads while checking via Chrome Status:

https://chromestatus.com/metrics/css/popularity

Thanks!

Comment 1 Ahmad Saleem 2023-03-02 14:51:19 PST

This got reverted - https://src.chromium.org/viewvc/blink?view=revision&revision=169514

Marking this as "RESOLVED INVALID".

Comment 2 Ahmad Saleem 2023-03-02 14:54:21 PST

This got commit with this as well - 169790 but without testcase.

https://src.chromium.org/viewvc/blink?revision=169790&view=revision

Reopening to get input from @Alan or @Simon or other Layout expert whether it is good performance fix or not?

Comment 3 EWS 2023-03-03 04:23:37 PST

Committed 261134@main (c13c03bc9729): <https://commits.webkit.org/261134@main>

Reviewed commits have been landed. Closing PR #10962 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-03-03 04:24:19 PST

<rdar://problem/106190746>