Bug 253209

Summary: AX: Enhanced Accessibility Mode breaks arrow-key scrolling for non-VoiceOver users
Product: WebKit Reporter: Cooper Barth <cooper_barth>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Major CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, thomas_mchugh, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 16   
Hardware: Mac (Apple Silicon)   
OS: Other   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Description Cooper Barth 2023-03-01 17:29:50 PST 
Enhanced Accessibility Mode breaks arrow-key scrolling for non-VoiceOver users.
Comment 1 Radar WebKit Bug Importer 2023-03-01 17:30:00 PST 
<rdar://problem/106115785>
Comment 2 Cooper Barth 2023-03-01 17:44:09 PST 
Created attachment 465253 [details]
Patch
Comment 3 Tommy McHugh 2023-03-01 17:50:30 PST 
I am slightly concerned about not doing this for FKA given the similar AX model between it and VO
Comment 4 chris fleizach 2023-03-01 19:02:00 PST 
Comment on attachment 465253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465253&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:224
> +    if (flag && client == kAXClientTypeVoiceOver)

This is an SPI that expects to be set. This will break that SPI

Also isn’t VO already setting this?
Comment 5 Cooper Barth 2023-03-03 15:38:51 PST 
After some further investigation, agreed that this patch likely isn't the correct fix, seeing as we do need to enter AssistiveControl to enter Enhanced Accessibility Mode for other non-scrolling related functionality.

A likely better fix would be to modify Enhanced Accessibility Mode to only disable scrolling if the client is VoiceOver. Ongoing discussion with the team as to whether this behavior should be enabled for Full Keyboard Access as well.
Comment 6 Cooper Barth 2023-04-13 11:29:26 PDT 
Moving this to do not fix - we're making a change on our end to resolve the issue.