Bug 253235
| Summary: | run-jsc-stress-tests should generate data test descriptions, not mixed code/data | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> |
| Component: | JavaScriptCore | Assignee: | Angelos Oikonomopoulos <angelos> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Angelos Oikonomopoulos
Mixing code and data in the generated test_script_NNNN files has significant disadvantages:
- makes it unreasonably hard to ensure that changes to the run* functions in run-jsc-stress-tests have the desired effect (and only the desired effect)
- the generated file is hard to follow for humans
- extracting the command to run needs a significant number of mouse/keyboard actions
- automatically extracting the command is even harder, making it difficult to write wrappers.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Angelos Oikonomopoulos
Pull request: https://github.com/WebKit/WebKit/pull/10931
Radar WebKit Bug Importer
<rdar://problem/106495046>