Bug 253366

Summary: Remove 'which' from 'KeyboardEvent.idl'
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: UI EventsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, karlcow, rniwa, tetsuharu.ohzeki, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-03-03 17:36:14 PST 
Hi Team,

We have this following FIXME: https://searchfox.org/wubkat/source/Source/WebCore/dom/UIEvent.idl#35

and Blink removed it as part of this commit - https://chromium.googlesource.com/chromium/src.git/+/cf13270c47f29b21ce7a8c937f598989cd66c840

Intent Thread of Blink - https://groups.google.com/a/chromium.org/g/blink-dev/c/6V4iHkqZXvQ

Just wanted to raise, so we can track the removal of this non-spec as well.

Thanks!
Comment 1 Tetsuharu Ohzeki [UTC+9] 2023-03-04 05:11:30 PST 
Gecko still have `UIEvent.which`
https://searchfox.org/mozilla-central/rev/e53063b2628e6e23d35ad1f7d786ab1a361051b7/dom/webidl/UIEvent.webidl#35

They also have a bug.
https://bugzilla.mozilla.org/show_bug.cgi?id=1186125


(In reply to Ahmad Saleem from comment #0)
> We have this following FIXME:
> https://searchfox.org/wubkat/source/Source/WebCore/dom/UIEvent.idl#35
> 
> and Blink removed it as part of this commit -
> https://chromium.googlesource.com/chromium/src.git/+/
> cf13270c47f29b21ce7a8c937f598989cd66c840
> 
> Intent Thread of Blink -
> https://groups.google.com/a/chromium.org/g/blink-dev/c/6V4iHkqZXvQ

In this context, I read that Blink removed `which` from **KeyboardEvent and MouseEvent** but not from **UIEvent**.

The spec also keep it as legacy interface
https://w3c.github.io/uievents/#legacy-interface-UIEvent

Hence, I think we can remove the FIXME but not remove `UIEvent.which` even if we sort our interface to Blink.
This bug title should be changed.
Comment 2 Ahmad Saleem 2023-03-04 06:02:27 PST 
(In reply to Tetsuharu Ohzeki [UTC+9] from comment #1)
> Gecko still have `UIEvent.which`
> https://searchfox.org/mozilla-central/rev/
> e53063b2628e6e23d35ad1f7d786ab1a361051b7/dom/webidl/UIEvent.webidl#35
> 
> They also have a bug.
> https://bugzilla.mozilla.org/show_bug.cgi?id=1186125
> 
> 
> (In reply to Ahmad Saleem from comment #0)
> > We have this following FIXME:
> > https://searchfox.org/wubkat/source/Source/WebCore/dom/UIEvent.idl#35
> > 
> > and Blink removed it as part of this commit -
> > https://chromium.googlesource.com/chromium/src.git/+/
> > cf13270c47f29b21ce7a8c937f598989cd66c840
> > 
> > Intent Thread of Blink -
> > https://groups.google.com/a/chromium.org/g/blink-dev/c/6V4iHkqZXvQ
> 
> In this context, I read that Blink removed `which` from **KeyboardEvent and
> MouseEvent** but not from **UIEvent**.
> 
> The spec also keep it as legacy interface
> https://w3c.github.io/uievents/#legacy-interface-UIEvent
> 
> Hence, I think we can remove the FIXME but not remove `UIEvent.which` even
> if we sort our interface to Blink.
> This bug title should be changed.

Thanks!

https://searchfox.org/wubkat/source/Source/WebCore/dom/KeyboardEvent.idl#51 & FIXME from https://searchfox.org/wubkat/source/Source/WebCore/dom/UIEvent.idl#35
Comment 3 Radar WebKit Bug Importer 2023-03-10 17:37:15 PST 
<rdar://problem/106580687>
Comment 4 EWS 2024-01-29 16:25:42 PST 
Committed 273701@main (df7782c2b48b): <https://commits.webkit.org/273701@main>

Reviewed commits have been landed. Closing PR #23339 and removing active labels.