Bug 253373

Summary: AX: Standalone spin buttons should be directly incrementable and decrementable
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2023-03-03 19:46:24 PST
Standalone spin buttons should be directly incrementable and decrementable.
Attachments
Patch (18.62 KB, patch)
2023-03-03 20:00 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (18.34 KB, patch)
2023-03-04 11:34 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (18.33 KB, patch)
2023-03-07 18:13 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (18.32 KB, patch)
2023-03-07 18:16 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-03 19:46:36 PST
<rdar://problem/106224266>
Tyler Wilcock
Comment 2 2023-03-03 20:00:31 PST
Created attachment 465288 [details] Patch
Tyler Wilcock
Comment 3 2023-03-04 11:34:19 PST
Created attachment 465293 [details] Patch
Andres Gonzalez
Comment 4 2023-03-06 08:38:12 PST
(In reply to Tyler Wilcock from comment #3) > Created attachment 465293 [details] > Patch Concerning the naming, can we use something like "simple" vs. "composite" instead of IncrementDecrement? Could we expose all spinbuttons as "simple"? i.e., why do we need to expose the separate increment and decrement buttons?
Tyler Wilcock
Comment 5 2023-03-07 18:12:20 PST
(In reply to Andres Gonzalez from comment #4) > (In reply to Tyler Wilcock from comment #3) > > Created attachment 465293 [details] > > Patch > > Concerning the naming, can we use something like "simple" vs. "composite" > instead of IncrementDecrement? Composite is a good name, thanks. I think I like "standalone" over "simple" as it's more descriptive and a better analogy to "composite". > Could we expose all spinbuttons as "simple"? i.e., why do we need to expose > the separate increment and decrement buttons? VoiceOver would handle the removal of these separate increment and decrement buttons just fine as long as the spinbutton itself exposes the increment and decrement actions. However, AppKit accessibility may expect attributes to be exposed for these separate spinbutton controls. I think we should explore whether we really need these attributes in a future patch.
Tyler Wilcock
Comment 6 2023-03-07 18:13:33 PST
Created attachment 465351 [details] Patch
Tyler Wilcock
Comment 7 2023-03-07 18:16:13 PST
Created attachment 465353 [details] Patch
EWS
Comment 8 2023-03-08 19:37:16 PST
Committed 261396@main (71206def1a57): <https://commits.webkit.org/261396@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465353 [details].
Note You need to log in before you can comment on or make changes to this bug.