Bug 253403

Summary:	Remove deadcode from SVGResourcesCache::clientStyleChanged
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	SVG	Assignee:	Rob Buis <rbuis>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-03-04 18:18:58 PST

Hi Team,

While going through Blink's commits, I came across another potential merge:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/3dbb235c9806036ecd531aa4eeae7ed1c4be89a7

WebKit Source Code - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGResourcesCache.cpp#169

^ Remove this IF condition and add these ASSERT at start of function:


    ASSERT(renderer);
    ASSERT(renderer.element());
    ASSERT(renderer.element()->isSVGElement());

_____

Just wanted to raise to get insight.

Thanks!

Comment 1 Radar WebKit Bug Importer 2023-03-11 18:19:14 PST

<rdar://problem/106605841>

Comment 2 Ahmad Saleem 2023-03-14 14:58:08 PDT

I tried in following PR - https://github.com/WebKit/WebKit/pull/11360

This leads to multiple test crashes on 'mac-AS-debug-wk2' instance.

Closing PR to investigate, what could be issue.

Comment 3 Rob Buis 2023-10-16 03:19:22 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19110

Comment 4 Rob Buis 2023-10-16 04:51:39 PDT

(In reply to Ahmad Saleem from comment #2)
> I tried in following PR - https://github.com/WebKit/WebKit/pull/11360
> 
> This leads to multiple test crashes on 'mac-AS-debug-wk2' instance.
> 
> Closing PR to investigate, what could be issue.

My new PR seems to work, possibly the crashes were due to the ASSERT not taking into account anonymous renderers.

Comment 5 EWS 2023-10-19 06:12:19 PDT

Committed 269518@main (cd8b6c24eddd): <https://commits.webkit.org/269518@main>

Reviewed commits have been landed. Closing PR #19110 and removing active labels.