Bug 253403
| Summary: | Remove deadcode from SVGResourcesCache::clientStyleChanged | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | SVG | Assignee: | Rob Buis <rbuis> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commits, I came across another potential merge:
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/3dbb235c9806036ecd531aa4eeae7ed1c4be89a7
WebKit Source Code - https://searchfox.org/wubkat/source/Source/WebCore/rendering/svg/SVGResourcesCache.cpp#169
^ Remove this IF condition and add these ASSERT at start of function:
ASSERT(renderer);
ASSERT(renderer.element());
ASSERT(renderer.element()->isSVGElement());
_____
Just wanted to raise to get insight.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106605841>
Ahmad Saleem
I tried in following PR - https://github.com/WebKit/WebKit/pull/11360
This leads to multiple test crashes on 'mac-AS-debug-wk2' instance.
Closing PR to investigate, what could be issue.
Rob Buis
Pull request: https://github.com/WebKit/WebKit/pull/19110
Rob Buis
(In reply to Ahmad Saleem from comment #2)
> I tried in following PR - https://github.com/WebKit/WebKit/pull/11360
>
> This leads to multiple test crashes on 'mac-AS-debug-wk2' instance.
>
> Closing PR to investigate, what could be issue.
My new PR seems to work, possibly the crashes were due to the ASSERT not taking into account anonymous renderers.
EWS
Committed 269518@main (cd8b6c24eddd): <https://commits.webkit.org/269518@main>
Reviewed commits have been landed. Closing PR #19110 and removing active labels.