Bug 253417
| Summary: | Remove extra call to 'layout' in Document::setParsing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit - I came across following, where we also have FIXME to rename function of similar:
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/56ef94099e79af642ee0ef5a3c8a3523c1ecc7dc
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/dom/Document.h#2319 etc.
^ There is FIXME as well in WebKit Source.
Do we need to merge this or come-up with better name?
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
alan
It looks like at this point this merge would only including the renaming part (WebKit does not schedule layout inside Document::setParsing)
Ahmad Saleem
(In reply to zalan from comment #1)
> It looks like at this point this merge would only including the renaming
> part (WebKit does not schedule layout inside Document::setParsing)
fireLayoutRelatedMilestonesIfNeeded() <- function, does it cause 'relayout'? Just from reading the code, it seems to be "Milestone" related something.
alan
(In reply to Ahmad Saleem from comment #2)
> (In reply to zalan from comment #1)
> > It looks like at this point this merge would only including the renaming
> > part (WebKit does not schedule layout inside Document::setParsing)
>
> fireLayoutRelatedMilestonesIfNeeded() <- function, does it cause 'relayout'?
No, it is not supposed to.
Ahmad Saleem
(In reply to zalan from comment #3)
> (In reply to Ahmad Saleem from comment #2)
> > (In reply to zalan from comment #1)
> > > It looks like at this point this merge would only including the renaming
> > > part (WebKit does not schedule layout inside Document::setParsing)
> >
> > fireLayoutRelatedMilestonesIfNeeded() <- function, does it cause 'relayout'?
> No, it is not supposed to.
Should I do PR for renaming purposes and get rid of FIXME, at least one less FIXME. As long as you are OK with 'm_isParsing' name instead of 'm_bParsing'?
alan
sounds good!
Radar WebKit Bug Importer
<rdar://problem/106621886>