Bug 253455
| Summary: | Fix SIMD global get and set in BBQ JIT | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | WebAssembly | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
rdar://106293111
The current implementation for global.get and global.set in BBQ JIT uses the same helper to emit type-correct load and store instructions as the rest of the WASM load and store ops. SIMD load ops aren't included in these instructions though, so whenever we try to get or set a v128 global with portable binding mode, we hit an ASSERT_NOT_REACHED.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/11126
EWS
Committed 261299@main (c6d7e1b115e0): <https://commits.webkit.org/261299@main>
Reviewed commits have been landed. Closing PR #11126 and removing active labels.