Bug 253530
| Summary: | Fix flushing constants to StackArguments in WasmBBQJIT | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | WebAssembly | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
rdar://106358707
The WASM BBQ JIT currently runs into some assertion failures when flushing constant values at the end of a block. This seems to be due to the fact that emitMoveConst checks specifically if the destination is a stack slot or global, and assumes it's a register otherwise. This breaks when we wind up with a constant bound to a StackArgument location (sp-relative, v.s. fp-relative for normal stack slots).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/11195
EWS
Committed 261358@main (65f37957e271): <https://commits.webkit.org/261358@main>
Reviewed commits have been landed. Closing PR #11195 and removing active labels.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/11330
EWS
Committed 261480@main (45c0db167f82): <https://commits.webkit.org/261480@main>
Reviewed commits have been landed. Closing PR #11330 and removing active labels.