Bug 253601
| Summary: | Improve build time by reducing includes of GraphicsLayer.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 253837 | ||
| Bug Blocks: | |||
Brent Fulgham
Benchmarking indicates that WebPage.h and WebPageProxy.h are expensive:
976056 ms: /Users/bfulgham/Projects/WebKit/OpenSource/Source/WebKit/UIProcess/WebPageProxy.h (included 78 times, avg 12513 ms), included via:
726039 ms: /Users/bfulgham/Projects/WebKit/OpenSource/Source/WebKit/WebProcess/WebPage/WebPage.h (included 60 times, avg 12100 ms), included via:
Code review shows that they are included in many places they are not needed, and that they include expensive headers that increase build time.
This patch improves build times by resolving some of these cases.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
WebPage.h drops from 12.1 seconds to about 7.4 seconds
Radar WebKit Bug Importer
<rdar://problem/106453112>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/11258
Brent Fulgham
Pull request: https://github.com/Webkit/WebKit/pull/11258
Brent Fulgham
Current PR:
Original Build (M1 Pro)
**** Time summary:
Compilation (10257 times):
Parsing (frontend): 8924.2 s
Codegen & opts (backend): 3158.1 s
Revised Build (M1 Pro)
**** Time summary:
Compilation (10188 times):
Parsing (frontend): 8529.2 s
Codegen & opts (backend): 3150.0 s
Brent Fulgham
I split this into a second patch: Bug 253837
EWS
Committed 261897@main (308d27ada88a): <https://commits.webkit.org/261897@main>
Reviewed commits have been landed. Closing PR #11258 and removing active labels.