| Summary: | [margin-trim] Trimmed block-start margins for boxes in a block container should be reflected in computed style | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | CSS | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/39705 | ||
| Bug Depends on: | |||
| Bug Blocks: | 253454 | ||
|
Description
Sammy Gill
2023-03-08 14:34:45 PST
Pull request: https://github.com/WebKit/WebKit/pull/11262 Circling back to this after working on the flex and grid cases. I think we can achieve this by adding some extra information in layout state when a block container has block-start margin trim specified on it. We will check if this state is set as we recurse into the nested children and use it to determine if those nested children should trim also. The nested content will also need to take into consideration some other pieces of information, such as if its children's margins can collapse with its margin before (e.g. it does not have any border/padding) Pull request: https://github.com/WebKit/WebKit/pull/12884 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/39705 Committed 263412@main (99e30b0ca8f6): <https://commits.webkit.org/263412@main> Reviewed commits have been landed. Closing PR #12884 and removing active labels. |