Bug 253629

Summary: Use a WeakPtr for InlineCSSStyleDeclaration::m_parentElement
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Chris Dumez
Reported 2023-03-08 22:06:04 PST
Use a WeakPtr for InlineCSSStyleDeclaration::m_parentElement. This is safer than keeping a raw pointer and avoids some work in the StyleElement destructor to clear this pointer.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-03-08 22:07:34 PST
Pull request: https://github.com/WebKit/WebKit/pull/11283
EWS
Comment 2 2023-03-09 08:50:43 PST
Committed 261440@main (a08f9d20cd53): <https://commits.webkit.org/261440@main> Reviewed commits have been landed. Closing PR #11283 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-03-09 08:51:17 PST
<rdar://problem/106502986>
Chris Dumez
Comment 4 2023-03-09 14:59:15 PST
Reverted by https://github.com/WebKit/WebKit/pull/11328
Chris Dumez
Comment 5 2023-03-09 14:59:16 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/11328
EWS
Comment 6 2023-03-09 15:16:24 PST
Committed 261475@main (7b7bf746e7bc): <https://commits.webkit.org/261475@main> Reviewed commits have been landed. Closing PR #11328 and removing active labels.
Chris Dumez
Comment 7 2023-03-10 09:04:41 PST
Re-opening for pull request https://github.com/WebKit/WebKit/pull/11365
EWS
Comment 8 2023-03-10 11:41:50 PST
Committed 261517@main (bbcee9c23927): <https://commits.webkit.org/261517@main> Reviewed commits have been landed. Closing PR #11365 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.