Bug 253651

Summary: [IFC][Partial layout] Replace a range of damaged line when the new content is PartialFromDamage
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Description zalan 2023-03-09 09:04:01 PST 
ssia
Comment 1 zalan 2023-03-09 09:10:15 PST 
Created attachment 465374 [details]
Patch
Comment 2 Antti Koivisto 2023-03-09 10:36:44 PST 
Comment on attachment 465374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465374&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:82
> +        auto canidateLineCount = lineLayoutResult.displayExtent == Layout::InlineFormattingContext::LineLayoutResult::DisplayExtent::FullFromDamage

that's a long name
Comment 3 zalan 2023-03-09 14:38:12 PST 
Created attachment 465383 [details]
Patch
Comment 4 zalan 2023-03-11 08:49:07 PST 
Created attachment 465396 [details]
Patch
Comment 5 zalan 2023-03-11 08:49:47 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 465374 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465374&action=review
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:82
> > +        auto canidateLineCount = lineLayoutResult.displayExtent == Layout::InlineFormattingContext::LineLayoutResult::DisplayExtent::FullFromDamage
> 
> that's a long name
yeah, got shortened.
Comment 6 zalan 2023-03-16 08:06:52 PDT 
Created attachment 465457 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2023-03-16 10:04:16 PDT 
<rdar://problem/106813274>
Comment 8 EWS 2023-03-16 16:26:21 PDT 
Committed 261775@main (38d7b8d0fd78): <https://commits.webkit.org/261775@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465457 [details].