Bug 253659

Summary:	[ iOS 16 ] imported/w3c/web-platform-tests/compat/idlharness.window.html is a constant failure.
Product:	WebKit	Reporter:	Bri Harris <bharris9>
Component:	New Bugs	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Bri Harris 2023-03-09 10:36:03 PST

imported/w3c/web-platform-tests/compat/idlharness.window.html

is a constant failure on iOS 16. 


HISTORY:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcompat%2Fidlharness.window.html


DIFF TEXT:

@@ -22,10 +22,10 @@
 PASS Element includes NonDocumentTypeChildNode: member names are unique
 PASS Element includes ChildNode: member names are unique
 PASS Element includes Slottable: member names are unique
-FAIL HTMLBodyElement interface: attribute onorientationchange assert_true: The prototype object must have a property "onorientationchange" expected true got false
-FAIL HTMLBodyElement interface: document.body must inherit property "onorientationchange" with the proper type assert_inherits: property "onorientationchange" not found in prototype chain
-FAIL Window interface: attribute orientation assert_own_property: The global object must have a property "orientation" expected property "orientation" missing
-FAIL Window interface: attribute onorientationchange assert_own_property: The global object must have a property "onorientationchange" expected property "onorientationchange" missing
-FAIL Window interface: window must inherit property "orientation" with the proper type assert_own_property: expected property "orientation" missing
-FAIL Window interface: window must inherit property "onorientationchange" with the proper type assert_own_property: expected property "onorientationchange" missing
+PASS HTMLBodyElement interface: attribute onorientationchange
+PASS HTMLBodyElement interface: document.body must inherit property "onorientationchange" with the proper type
+PASS Window interface: attribute orientation
+PASS Window interface: attribute onorientationchange
+PASS Window interface: window must inherit property "orientation" with the proper type
+PASS Window interface: window must inherit property "onorientationchange" with the proper type

Comment 1 Radar WebKit Bug Importer 2023-03-09 10:48:06 PST

<rdar://problem/106509792>

Comment 2 Bri Harris 2023-03-09 11:32:24 PST

I was able to replicate this failure on iOS ToT as follows:

run-webkit-tests --root imported/w3c/web-platform-tests/compat/idlharness.window.html

Comment 3 Bri Harris 2023-03-09 11:36:35 PST

It appears commit 261282@main appears to be related. I verified that tests were passing on commit 261281@main but failed on 261282@main. 


LINK TO REFERENCED COMMIT:
https://commits.webkit.org/261282@main

Comment 4 Ryan Haddad 2023-03-09 11:42:12 PST

(In reply to Bri Harris from comment #3)
> It appears commit 261282@main appears to be related. I verified that tests
> were passing on commit 261281@main but failed on 261282@main. 
> 
> 
> LINK TO REFERENCED COMMIT:
> https://commits.webkit.org/261282@main

This makes sense! It looks like the test was rebaselined in that commit there because the feature was disabled for non-mobile devices, but since iOS will support it (as evidenced by the unexpectedly passing subtests above) we need a new platform baseline.

Comment 5 Chris Dumez 2023-03-09 11:44:16 PST

(In reply to Ryan Haddad from comment #4)
> (In reply to Bri Harris from comment #3)
> > It appears commit 261282@main appears to be related. I verified that tests
> > were passing on commit 261281@main but failed on 261282@main. 
> > 
> > 
> > LINK TO REFERENCED COMMIT:
> > https://commits.webkit.org/261282@main
> 
> This makes sense! It looks like the test was rebaselined in that commit
> there because the feature was disabled for non-mobile devices, but since iOS
> will support it (as evidenced by the unexpectedly passing subtests above) we
> need a new platform baseline.

Yes, this just needs an iOS-specific baseline.

Comment 6 Chris Dumez 2023-03-09 12:04:40 PST

Pull request: https://github.com/WebKit/WebKit/pull/11318

Comment 7 EWS 2023-03-09 12:12:03 PST

Committed 261456@main (55c53e931f2e): <https://commits.webkit.org/261456@main>

Reviewed commits have been landed. Closing PR #11318 and removing active labels.