Bug 253666

Summary: Worklet.prototype.constructor is incorrect
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Generated file none

Don Olmstead
Reported 2023-03-09 12:00:25 PST
Created attachment 465378 [details] Generated file In non-unified builds the value `JSWorkletPrototypeTableValues` is reported as unused in the generated `JSWorklet.cpp`. /* Hash table for prototype */ static const HashTableValue JSWorkletPrototypeTableValues[] = { { "constructor"_s, static_cast<unsigned>(PropertyAttribute::DontEnum), NoIntrinsic, { HashTableValue::GetterSetterType, jsWorkletConstructor, 0 } }, };
Attachments
Generated file (11.30 KB, text/plain)
2023-03-09 12:00 PST, Don Olmstead 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2023-03-09 12:04:18 PST
[1329/4747] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/JSWorklet.cpp.o FAILED: C:/GitHub/WebKit/WebKitBuild/clang-16/WebCore/DerivedSources/JSWorklet.cpp:135:29: error: unused variable 'JSWorkletPrototypeTableValues' [-Werror,-Wunused-const-variable] static const HashTableValue JSWorkletPrototypeTableValues[] = ^ 1 error generated.
Chris Dumez
Comment 2 2023-03-09 12:43:51 PST
Pull request: https://github.com/WebKit/WebKit/pull/11322
EWS
Comment 3 2023-03-09 19:17:10 PST
Committed 261483@main (1976601ac162): <https://commits.webkit.org/261483@main> Reviewed commits have been landed. Closing PR #11322 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2023-03-09 19:18:17 PST
<rdar://problem/106533500>
Note You need to log in before you can comment on or make changes to this bug.