Bug 253725

Summary: Add <functional> to precompiled header set
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Brent Fulgham
Reported 2023-03-10 11:14:36 PST
One of the most costly headers across the build is boyer_moore_searcher.h, which is used inside <functional>. The file is included 2499 times. Before the proposed change: **** Time summary: Compilation (10226 times): Parsing (frontend): 9479.2 s Codegen & opts (backend): 3429.0 s With the change: **** Time summary: Compilation (10196 times): Parsing (frontend): 9312.7 s Codegen & opts (backend): 3316.7 s Roughly a savings of 2.75 CPU minutes in parsing, and close to 2 CPU minutes in codegen.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-03-10 11:15:52 PST
Brent Fulgham
Comment 2 2023-03-10 11:19:13 PST
EWS
Comment 3 2023-03-10 15:02:13 PST
Committed 261531@main (1f6f5b1e5d87): <https://commits.webkit.org/261531@main> Reviewed commits have been landed. Closing PR #11374 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.