Bug 253736
| Summary: | V8 huge memory tests for WASM should be skipped on memory limited platforms | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | WebAssembly | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
rdar://106216553
The following V8 WASM tests:
- grow-huge-memory.js
- huge-memory.js
- huge-typedarray.js
are designed to test that WASM memories larger than 2GB are correctly supported. We pass this reliably on most platforms. However, some of our test runners are memory limited, and simply don't have enough available memory to allocate the WASM memory, instead failing with an OOM. We should skip these tests on memory limited platforms, consistent with existing JS stress tests that allocate large (>10MB) arrays and buffers.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/11384
EWS
Committed 261577@main (d12810b70871): <https://commits.webkit.org/261577@main>
Reviewed commits have been landed. Closing PR #11384 and removing active labels.