Bug 253749
| Summary: | github.com is broken | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kdwk <kdwkleung> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, xry111 |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Kdwk
Navigating to github.com on Epiphany Tech Preview results in a white page.
Epiphany Tech Preview 44.rc-19-ga80fcd0ab+, WebKitGTK 2.39.91
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Xi Ruoyao
I've reported https://github.com/orgs/community/discussions/49755.
Michael Catanzaro
Time for a mandatory break from WebKit development. :P Cannot view that discussion or any pull requests.
Interestingly, it does work if I use Epiphany 43 with WebKitGTK 2.38 for whatever reason, so I can see the problem is we're missing navigator.clipboard.read.
Michael Catanzaro
(In reply to Michael Catanzaro from comment #2)
> Interestingly, it does work if I use Epiphany 43 with WebKitGTK 2.38 for
> whatever reason
Ah no, I just got unlucky. It's broken in both versions but sometimes the page content displays anyway.
Michael Catanzaro
This is the missing API:
# FIXME: This is on by default in WebKit2 PLATFORM(COCOA). Perhaps we should consider turning it on for WebKitLegacy as well.
AsyncClipboardAPIEnabled:
type: bool
status: mature
humanReadableName: "Async clipboard API"
humanReadableDescription: "Enable the async clipboard API"
defaultValue:
WebKitLegacy:
default: false
WebKit:
"PLATFORM(COCOA)" : true
default: false
WebCore:
default: false
I'm surprised this sort of breakage does not happen more often since we're not very good at keeping up with new web APIs.
It looks like the implementation in Source/WebCore/Modules/async-clipboard is entirely cross-platform (build on top of our existing clipboard platform abstractions) and the only platform-specific bits are the image reader, so... maybe we can just turn it on.
Xi Ruoyao
(In reply to Michael Catanzaro from comment #4)
> This is the missing API:
>
> # FIXME: This is on by default in WebKit2 PLATFORM(COCOA). Perhaps we should
> consider turning it on for WebKitLegacy as well.
> AsyncClipboardAPIEnabled:
> type: bool
> status: mature
> humanReadableName: "Async clipboard API"
> humanReadableDescription: "Enable the async clipboard API"
> defaultValue:
> WebKitLegacy:
> default: false
> WebKit:
> "PLATFORM(COCOA)" : true
> default: false
> WebCore:
> default: false
>
> I'm surprised this sort of breakage does not happen more often since we're
> not very good at keeping up with new web APIs.
>
> It looks like the implementation in Source/WebCore/Modules/async-clipboard
> is entirely cross-platform (build on top of our existing clipboard platform
> abstractions) and the only platform-specific bits are the image reader,
> so... maybe we can just turn it on.
Even if we don't turn it on, I think GitHub developers should not make a dead loop in the JavaScript code...
Michael Catanzaro
*** This bug has been marked as a duplicate of bug 211979 ***