Bug 253765

Summary:	Update Document::m_ranges to be a WeakHashSet
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	DOM	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	commit-queue, Hironori.Fujii, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	253875
Bug Blocks:

Description Chris Dumez 2023-03-11 15:57:08 PST

Update Document::m_ranges to be a WeakHashSet.

Comment 1 Chris Dumez 2023-03-11 15:58:51 PST

Pull request: https://github.com/WebKit/WebKit/pull/11407

Comment 2 EWS 2023-03-13 13:30:51 PDT

Committed 261586@main (a526a939ab0c): <https://commits.webkit.org/261586@main>

Reviewed commits have been landed. Closing PR #11407 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-03-13 13:31:16 PDT

<rdar://problem/106660404>

Comment 4 Fujii Hironori 2023-03-14 00:31:22 PDT

The assertion is randomly crashing.

> ASSERTION FAILED: m_ranges.isEmptyIgnoringNullReferences()
> dom/Document.cpp(716) : virtual WebCore::Document::~Document()

https://results.webkit.org/?suite=layout-tests&test=editing%2Fdeleting%2Fdelete-block-merge-contents-011.html
https://ews-build.webkit.org/#/builders/84/builds/9917

Comment 5 WebKit Commit Bot 2023-03-14 00:36:07 PDT

Re-opened since this is blocked by bug 253875

Comment 6 Fujii Hironori 2023-03-14 14:04:48 PDT

Thank you for fixing. Closed again.