Bug 253765

Summary: Update Document::m_ranges to be a WeakHashSet
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fujii.hironori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 253875    
Bug Blocks:    

Chris Dumez
Reported 2023-03-11 15:57:08 PST
Update Document::m_ranges to be a WeakHashSet.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-03-11 15:58:51 PST
Pull request: https://github.com/WebKit/WebKit/pull/11407
EWS
Comment 2 2023-03-13 13:30:51 PDT
Committed 261586@main (a526a939ab0c): <https://commits.webkit.org/261586@main> Reviewed commits have been landed. Closing PR #11407 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-03-13 13:31:16 PDT
<rdar://problem/106660404>
Fujii Hironori
Comment 4 2023-03-14 00:31:22 PDT
The assertion is randomly crashing. > ASSERTION FAILED: m_ranges.isEmptyIgnoringNullReferences() > dom/Document.cpp(716) : virtual WebCore::Document::~Document() https://results.webkit.org/?suite=layout-tests&test=editing%2Fdeleting%2Fdelete-block-merge-contents-011.html https://ews-build.webkit.org/#/builders/84/builds/9917
WebKit Commit Bot
Comment 5 2023-03-14 00:36:07 PDT
Re-opened since this is blocked by bug 253875
Fujii Hironori
Comment 6 2023-03-14 14:04:48 PDT
Thank you for fixing. Closed again.
Note You need to log in before you can comment on or make changes to this bug.