Bug 253771
| Summary: | Delete odd assignment of IgnoreOverlayScrollbarSize | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another potential merge and I have tested this locally on --release build and does not seem to cause any issue. Although EWS or Debug builds might have other story to tell.
NOTE - Motivation to merge is to get rid of "FIXME" and deadcode is deadcode:
____
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/bd25c52a9a4dcd09e0ed47ba300cf82e86b28cb7
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderLayer.cpp#4480
^ Removed:
ClipRectsContext parentContext(clipRectsContext);
parentContext.options.remove(ClipRectsOption::IncludeOverlayScrollbarSize); // FIXME: Why?
if ((parentContext.clipRectsType != TemporaryClipRects && parentContext.clipRectsType != AbsoluteClipRects) && clipCrossesPaintingBoundary())
parentContext.clipRectsType = TemporaryClipRects;
_____
Replaced:
parentLayer->calculateClipRects(parentContext, clipRects);
with
parentLayer->calculateClipRects(clipRectsContext, clipRects);
____
Just wanted to raise to get input.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
*** This bug has been marked as a duplicate of bug 253770 ***