Bug 253775

Summary: [IFC][Partial layout] Editing constructs individual renderers for "new line" when typing in textarea
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

Description zalan 2023-03-11 19:53:37 PST
ssia
Comment 1 zalan 2023-03-11 20:09:30 PST
Created attachment 465399 [details]
Patch
Comment 2 zalan 2023-03-11 21:27:29 PST
Created attachment 465400 [details]
Patch
Comment 3 Antti Koivisto 2023-03-12 12:12:47 PDT
--- a/Source/WebCore/layout/layouttree/LayoutElementBox.cpp
+++ b/Source/WebCore/layout/layouttree/LayoutElementBox.cpp
@@ -118,6 +118,29 @@ void ElementBox::appendChild(UniqueRef<Box> childRef)
     nextOrFirst = WTFMove(childBox);
 }
 
+void ElementBox::insertChild(UniqueRef<Box> childRef, Box* beforeChild)
+{

we can probably replace use of appendChild with insertChild(child, nullptr)
Comment 4 zalan 2023-03-12 15:53:48 PDT
Created attachment 465407 [details]
Patch
Comment 5 zalan 2023-03-13 06:45:01 PDT
Created attachment 465418 [details]
Patch
Comment 6 zalan 2023-03-13 08:21:33 PDT
Created attachment 465421 [details]
Patch
Comment 7 zalan 2023-03-17 05:56:19 PDT
Created attachment 465474 [details]
Patch
Comment 8 zalan 2023-03-18 07:44:35 PDT
Created attachment 465491 [details]
Patch
Comment 9 zalan 2023-03-18 14:52:46 PDT
Created attachment 465495 [details]
[fast-cq]Patch
Comment 10 EWS 2023-03-18 19:29:43 PDT
Committed 261833@main (2dbdc010d549): <https://commits.webkit.org/261833@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465495 [details].
Comment 11 Radar WebKit Bug Importer 2023-03-18 19:30:17 PDT
<rdar://problem/106904861>