Bug 253796

Summary: AX: Reduce main-thread hits for descriptionAttributeValue, titleAttributeValue, and accessibilityHitTest
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: andresg_22, cfleizach, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2023-03-12 12:50:16 PDT
For AccessibilityRole::StaticText objects, descriptionAttributeValue and titleAttributeValue are hardcoded to return empty string. We know an object's role value before going to the main-thread, so let's use this information. Also, accessibilityHitTest goes to the main-thread to access AXCoreObject::widget without checking AXCoreObject::isWidget first, which incurs unnecessary main-thread hits for things that are not widgets.
Attachments
Patch (8.93 KB, patch)
2023-03-12 13:08 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.97 KB, patch)
2023-03-12 13:46 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.97 KB, patch)
2023-03-12 17:19 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-03-12 12:50:25 PDT
<rdar://problem/106619115>
Tyler Wilcock
Comment 2 2023-03-12 13:08:55 PDT
Created attachment 465404 [details] Patch
Tyler Wilcock
Comment 3 2023-03-12 13:46:55 PDT
Created attachment 465405 [details] Patch
Tyler Wilcock
Comment 4 2023-03-12 17:19:35 PDT
Created attachment 465410 [details] Patch
EWS
Comment 5 2023-03-14 11:14:45 PDT
Committed 261642@main (9d4124105e23): <https://commits.webkit.org/261642@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465410 [details].
Note You need to log in before you can comment on or make changes to this bug.