Bug 253812
| Summary: | [Win] Remove DLLLauncherMain.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <fujii.hironori> |
| Component: | CMake | Assignee: | Fujii Hironori <fujii.hironori> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | don.olmstead, stephan.szabo, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Fujii Hironori
[Win] Remove DLLLauncherMain.cpp
AppleWin has gone. We no longer need DLLLauncherMain.cpp that make CMake complicated.
However, we have to set the path to WebKitLibraries/win/bin64, or copy all DLLs.
> path %WEBKIT_LIBRARIES%\bin64;%path%
I prefer the former.
WinCairo tester buildbots also have to set the path.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/11435
Stephan Szabo
It's unclear to me by what you mean by setting the path? Do you mean that the user of the binary needs to set the path? If so, I'm not convinced that's a good tradeoff, especially not without a lot more discussion involved.
Radar WebKit Bug Importer
<rdar://problem/106932734>
EWS
Committed 265819@main (21785f58f0ef): <https://commits.webkit.org/265819@main>
Reviewed commits have been landed. Closing PR #11435 and removing active labels.