Bug 253820

Summary:	Use bridge instead of reinterpret_cast to convert between NS and CF objects.
Product:	WebKit	Reporter:	Seija K. <doremylover123>
Component:	Web Template Framework	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ddkilzer, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	255243

Description Seija K. 2023-03-13 06:34:11 PDT

The current approach is very hacky and the compiler probably doesn't have a strong idea of what is going on compared to when the __bridge macro is used.

Comment 1 Seija K. 2023-03-13 06:37:49 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11420

Comment 2 EWS 2023-03-20 00:04:36 PDT

Committed 261860@main (b6a50d258a8e): <https://commits.webkit.org/261860@main>

Reviewed commits have been landed. Closing PR #11420 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-03-20 00:06:17 PDT

<rdar://problem/106931170>

Comment 4 David Kilzer (:ddkilzer) 2023-05-03 09:28:33 PDT

This caused:

Bug 255243: REGRESSION (iOS 16.4 / macOS 13.3): TestWTF.TypeCastsCocoaARC.bridge_cast is a constant failure
<https://bugs.webkit.org/show_bug.cgi?id=255243>

The change to `Source/WTF/wtf/cocoa/TypeCastsCocoa.h` needs to be rolled out until we can find an acceptable fix for iOS 16.4+ and macOS 13.3+.  (The change is the correct thing to do, but it requires fixes in other areas before it can re-land.)