Bug 253837
| Summary: | Reduce some costly includes from WebPage.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Fujii Hironori <fujii.hironori> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 253601 | ||
Brent Fulgham
This is a subset of the mega-patch in Bug 253601.
Benchmarking shows that WebPage.h is very costly to parse due to a few heavyweight includes. We can improve build time by using more specific includes where appropriate, and forward declare classes when possible.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106655602>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/11451
Brent Fulgham
Pull request: https://github.com/Webkit/WebKit/pull/11451
EWS
Committed 261710@main (d59dce7984ad): <https://commits.webkit.org/261710@main>
Reviewed commits have been landed. Closing PR #11451 and removing active labels.
Fujii Hironori
Re-opening for pull request https://github.com/WebKit/WebKit/pull/11574
EWS
Committed 261715@main (baddb1e77fcb): <https://commits.webkit.org/261715@main>
Reviewed commits have been landed. Closing PR #11574 and removing active labels.
Fujii Hironori
Hmm, GTK/WPE are still broken. WinCairo/PlayStation got back to green.
Brent Fulgham
It looks like your fix should work for WPE/GTK, too. They are complaining about Logging in debug build for the same symbols you just landed.
Fujii Hironori
Ah, you are right. I checked a wrong revision. GTK is green. WPE bot is still building.