Bug 253854

Summary:	[ iOS ] imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html is a constant text only failure.
Product:	WebKit	Reporter:	Bri Harris <bharris9>
Component:	New Bugs	Assignee:	Tim Nguyen (:ntim) <ntim>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Bri Harris 2023-03-13 16:34:48 PDT

imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html

is a constant text only failure on iOS 16. 


HISTORY:

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fpopovers%2Fpopover-focus.html



I was able to replicate this failure at iOS 16 ToT on Apple Silicon as follows:

run-webkit-tests --root imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html

Comment 1 Bri Harris 2023-03-13 16:35:01 PDT

DIFF TEXT:


@@ -2,16 +2,16 @@
 
 autofocus button  second autofocus button
 
-FAIL Popover focus test: default behavior - popover is not focused assert_equals: default behavior - popover is not focused activated by popover.showPopover() expected Element node <button id="priorFocus"></button> but got Element node <button>first button</button>
+FAIL Popover focus test: default behavior - popover is not focused assert_false: expected false got true
 FAIL Popover button click focus test: default behavior - popover is not focused assert_false: popover should start out hidden expected false got true
 PASS Popover corner cases test: default behavior - popover is not focused
-FAIL Popover focus test: autofocus popover assert_equals: autofocus popover activated by popover.showPopover() expected Element node <div popover="" data-test="autofocus popover" autofocus="... but got Element node <button id="priorFocus"></button>
+FAIL Popover focus test: autofocus popover assert_equals: prior element should get focus after Escape expected Element node <button id="priorFocus"></button> but got Element node <div popover="" data-test="autofocus popover" autofocus="...
 FAIL Popover button click focus test: autofocus popover assert_false: popover should start out hidden expected false got true
 FAIL Popover corner cases test: autofocus popover assert_false: popover should start out hidden expected false got true
-FAIL Popover focus test: autofocus empty popover assert_equals: autofocus empty popover activated by popover.showPopover() expected Element node <div popover="" data-test="autofocus empty popover" autof... but got Element node <button id="priorFocus"></button>
+FAIL Popover focus test: autofocus empty popover assert_equals: prior element should get focus after Escape expected Element node <button id="priorFocus"></button> but got Element node <div popover="" data-test="autofocus empty popover" autof...
 FAIL Popover button click focus test: autofocus empty popover assert_false: popover should start out hidden expected false got true
 FAIL Popover corner cases test: autofocus empty popover assert_false: popover should start out hidden expected false got true
-FAIL Popover focus test: autofocus popover with button assert_equals: autofocus popover with button activated by popover.showPopover() expected Element node <div popover="" data-test="autofocus popover with button"... but got Element node <button>button</button>
+FAIL Popover focus test: autofocus popover with button assert_equals: prior element should get focus after Escape expected Element node <button id="priorFocus"></button> but got Element node <div popover="" data-test="autofocus popover with button"...
 FAIL Popover button click focus test: autofocus popover with button assert_false: popover should start out hidden expected false got true
 FAIL Popover corner cases test: autofocus popover with button assert_false: popover should start out hidden expected false got true
 FAIL Popover focus test: autofocus child assert_equals: prior element should get focus after Escape expected Element node <button id="priorFocus"></button> but got Element node <button autofocus="" class="should-be-focused">autofocus ...
@@ -23,7 +23,7 @@
 FAIL Popover focus test: autofocus multiple children assert_equals: prior element should get focus after Escape expected Element node <button id="priorFocus"></button> but got Element node <button autofocus="" class="should-be-focused">autofocus ...
 FAIL Popover button click focus test: autofocus multiple children assert_false: popover should start out hidden expected false got true
 FAIL Popover corner cases test: autofocus multiple children assert_false: popover should start out hidden expected false got true
-FAIL Popover focus test: autofocus popover and multiple autofocus children assert_equals: autofocus popover and multiple autofocus children activated by popover.showPopover() expected Element node <div popover="" autofocus="" tabindex="-1" data-test="aut... but got Element node <button autofocus="">autofocus button</button>
+FAIL Popover focus test: autofocus popover and multiple autofocus children assert_equals: prior element should get focus after Escape expected Element node <button id="priorFocus"></button> but got Element node <div popover="" autofocus="" tabindex="-1" data-test="aut...
 FAIL Popover button click focus test: autofocus popover and multiple autofocus children assert_false: popover should start out hidden expected false got true
 FAIL Popover corner cases test: autofocus popover and multiple autofocus children assert_false: popover should start out hidden expected false got true

Comment 2 Radar WebKit Bug Importer 2023-03-13 16:35:22 PDT

<rdar://problem/106671840>

Comment 3 Tim Nguyen (:ntim) 2023-03-13 21:05:34 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11477

Comment 4 EWS 2023-03-13 21:11:16 PDT

Test gardening commit 261613@main (6767b8c848ab): <https://commits.webkit.org/261613@main>

Reviewed commits have been landed. Closing PR #11477 and removing active labels.