Bug 253933
| Summary: | Correct RenderListMarker::styleDidChange check for list-style-type after 261651@main | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
The new check in 261651@main is incorrect, we can simply remove the `style().listStyleType().type == ListStyleType::Type::String` part.
The `style().listStyleType() != oldStyle->listStyleType()` now covers the string case too, since ListStyleType's equality operator checks both the identifier and the type.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/106737094>
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/11539
EWS
Committed 261675@main (2d0106d057af): <https://commits.webkit.org/261675@main>
Reviewed commits have been landed. Closing PR #11539 and removing active labels.