Bug 253986

CRASH LOG TEXT: ASSERTION FAILED: ident.impl() && ident.impl()->bufferOwnership() == StringImpl::BufferInternal /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Source/WebGPU/WGSL/Token.h(153) : WGSL::Token::Token(WGSL::TokenType, WGSL::SourcePosition, unsigned int, WTF::String &&) 1 0x101438939 WTFCrash 2 0x10125e1eb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x1013a7903 WGSL::Token::Token(WGSL::TokenType, WGSL::SourcePosition, unsigned int, WTF::String&&) 4 0x1013a4b55 WGSL::Token::Token(WGSL::TokenType, WGSL::SourcePosition, unsigned int, WTF::String&&) 5 0x1013a4a2c WGSL::Lexer<unsigned char>::makeIdentifierToken(WTF::String&&) 6 0x1013a3d4a WGSL::Lexer<unsigned char>::lex() 7 0x1013c9a5c WGSL::Parser<WGSL::Lexer<unsigned char> >::consumeType(WGSL::TokenType) 8 0x1013cd4e8 WGSL::Parser<WGSL::Lexer<unsigned char> >::parseAttribute() 9 0x1013c9d74 WGSL::Parser<WGSL::Lexer<unsigned char> >::parseAttributes() 10 0x1013c90d7 WGSL::Parser<WGSL::Lexer<unsigned char> >::parseGlobalDecl() 11 0x1013c8bfc WGSL::Parser<WGSL::Lexer<unsigned char> >::parseShader() 12 0x1013c7dda std::__1::optional<WGSL::CompilationMessage> WGSL::parse<WGSL::Lexer<unsigned char> >(WGSL::ShaderModule&) 13 0x1013c7d46 WGSL::parse(WGSL::ShaderModule&) 14 0x10125c475 TestWGSLAPI::WGSLASTDumperTests_dumpTriangleVert_Test::TestBody() 15 0x10135e1bb void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 16 0x1013213ba void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 17 0x101321303 testing::Test::Run() 18 0x101322481 testing::TestInfo::Run() 19 0x101323524 testing::TestSuite::Run() 20 0x1013326bb testing::internal::UnitTestImpl::RunAllTests() 21 0x1013630fb bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 22 0x10133207a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 23 0x101331f65 testing::UnitTest::Run() 24 0x1012a8431 RUN_ALL_TESTS() 25 0x1012a83c6 TestWebKitAPI::TestsController::run(int, char**) 26 0x101275277 main 27 0x7ff805aec310 start

<rdar://problem/106775188>

I was able to reproduce this crash at Ventura ToT as follows: run-api-tests --no-build TestWGSL.WGSLASTDumperTests.dumpTriangleVert --debug --verbose I was able to verify regression by running this test at 261690@main with the test crashing. This crash was not reproduced on 261689@main or 261686@main or prior.

The culprit was reverted in https://commits.webkit.org/261722@main