Bug 253986

Summary: [ macOS ] 31 x TestWGSL API Tests are constant crashes.
Product: WebKit Reporter: Bri Harris <bharris9>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   

Description Bri Harris 2023-03-15 15:01:58 PDT 
These 31 TestWGSL API Tests:

    TestWGSL.WGSLASTDumperTests.dumpTriangleVert
    TestWGSL.WGSLLexerTests.ComputeShader
    TestWGSL.WGSLLexerTests.GraphicsShader
    TestWGSL.WGSLLexerTests.TriangleVert
    TestWGSL.WGSLMetalGenerationTests.BuiltinSampleMask
    TestWGSL.WGSLMetalGenerationTests.RedFrag
    TestWGSL.WGSLParserTest.ShortCircuitAndExpression
    TestWGSL.WGSLParserTest.ShortCircuitOrExpression
    TestWGSL.WGSLParserTests.ArrayAccess
    TestWGSL.WGSLParserTests.BinaryBitwiseExpression
    TestWGSL.WGSLParserTests.BinaryExpression
    TestWGSL.WGSLParserTests.BinaryExpression2
    TestWGSL.WGSLParserTests.BinaryLeftShiftExpression
    TestWGSL.WGSLParserTests.BinaryRightShiftExpression
    TestWGSL.WGSLParserTests.FunctionDecl
    TestWGSL.WGSLParserTests.GlobalConstant
    TestWGSL.WGSLParserTests.GlobalOverride
    TestWGSL.WGSLParserTests.GlobalVariable
    TestWGSL.WGSLParserTests.LocalConstant
    TestWGSL.WGSLParserTests.LocalLet
    TestWGSL.WGSLParserTests.LocalVariable
    TestWGSL.WGSLParserTests.RedFrag
    TestWGSL.WGSLParserTests.RelationalExpression
    TestWGSL.WGSLParserTests.SourceLifecycle
    TestWGSL.WGSLParserTests.Struct
    TestWGSL.WGSLParserTests.TriangleVert
    TestWGSL.WGSLParserTests.TrivialGraphicsShader
    TestWGSL.WGSLParserTests.UnaryExpression
    TestWGSL.WGSLParserTests.UnaryExpression2
    TestWGSL.WGSLParserTests.VectorWithComponentType
    TestWGSL.WGSLParserTests.VectorWithOutComponentType

are all constant crashes on macOS. 


HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWGSL.WGSLASTDumperTests.dumpTriangleVert&test=TestWGSL.WGSLLexerTests.ComputeShader&test=TestWGSL.WGSLLexerTests.GraphicsShader&test=TestWGSL.WGSLLexerTests.TriangleVert&test=TestWGSL.WGSLMetalGenerationTests.BuiltinSampleMask&test=TestWGSL.WGSLMetalGenerationTests.RedFrag&test=TestWGSL.WGSLParserTest.ShortCircuitAndExpression&test=TestWGSL.WGSLParserTest.ShortCircuitOrExpression&test=TestWGSL.WGSLParserTests.ArrayAccess&test=TestWGSL.WGSLParserTests.BinaryBitwiseExpression&test=TestWGSL.WGSLParserTests.BinaryExpression&test=TestWGSL.WGSLParserTests.BinaryExpression2&test=TestWGSL.WGSLParserTests.BinaryExpression3&test=TestWGSL.WGSLParserTests.BinaryExpression4&test=TestWGSL.WGSLParserTests.BinaryLeftShiftExpression&test=TestWGSL.WGSLParserTests.BinaryRightShiftExpression&test=TestWGSL.WGSLParserTests.FunctionDecl&test=TestWGSL.WGSLParserTests.GlobalConstant&test=TestWGSL.WGSLParserTests.GlobalOverride&test=TestWGSL.WGSLParserTests.GlobalVariable&test=TestWGSL.WGSLParserTests.LocalConstant&test=TestWGSL.WGSLParserTests.LocalLet&test=TestWGSL.WGSLParserTests.LocalVariable&test=TestWGSL.WGSLParserTests.RedFrag&test=TestWGSL.WGSLParserTests.RelationalExpression&test=TestWGSL.WGSLParserTests.SourceLifecycle&test=TestWGSL.WGSLParserTests.Struct&test=TestWGSL.WGSLParserTests.TriangleVert&test=TestWGSL.WGSLParserTests.TrivialGraphicsShader&test=TestWGSL.WGSLParserTests.UnaryExpression&test=TestWGSL.WGSLParserTests.UnaryExpression2&test=TestWGSL.WGSLParserTests.VectorWithComponentType&test=TestWGSL.WGSLParserTests.VectorWithOutComponentType
Comment 1 Bri Harris 2023-03-15 15:02:18 PDT 
CRASH LOG TEXT:


ASSERTION FAILED: ident.impl() && ident.impl()->bufferOwnership() == StringImpl::BufferInternal
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Source/WebGPU/WGSL/Token.h(153) : WGSL::Token::Token(WGSL::TokenType, WGSL::SourcePosition, unsigned int, WTF::String &&)
        1   0x101438939 WTFCrash
        2   0x10125e1eb WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x1013a7903 WGSL::Token::Token(WGSL::TokenType, WGSL::SourcePosition, unsigned int, WTF::String&&)
        4   0x1013a4b55 WGSL::Token::Token(WGSL::TokenType, WGSL::SourcePosition, unsigned int, WTF::String&&)
        5   0x1013a4a2c WGSL::Lexer<unsigned char>::makeIdentifierToken(WTF::String&&)
        6   0x1013a3d4a WGSL::Lexer<unsigned char>::lex()
        7   0x1013c9a5c WGSL::Parser<WGSL::Lexer<unsigned char> >::consumeType(WGSL::TokenType)
        8   0x1013cd4e8 WGSL::Parser<WGSL::Lexer<unsigned char> >::parseAttribute()
        9   0x1013c9d74 WGSL::Parser<WGSL::Lexer<unsigned char> >::parseAttributes()
        10  0x1013c90d7 WGSL::Parser<WGSL::Lexer<unsigned char> >::parseGlobalDecl()
        11  0x1013c8bfc WGSL::Parser<WGSL::Lexer<unsigned char> >::parseShader()
        12  0x1013c7dda std::__1::optional<WGSL::CompilationMessage> WGSL::parse<WGSL::Lexer<unsigned char> >(WGSL::ShaderModule&)
        13  0x1013c7d46 WGSL::parse(WGSL::ShaderModule&)
        14  0x10125c475 TestWGSLAPI::WGSLASTDumperTests_dumpTriangleVert_Test::TestBody()
        15  0x10135e1bb void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        16  0x1013213ba void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        17  0x101321303 testing::Test::Run()
        18  0x101322481 testing::TestInfo::Run()
        19  0x101323524 testing::TestSuite::Run()
        20  0x1013326bb testing::internal::UnitTestImpl::RunAllTests()
        21  0x1013630fb bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        22  0x10133207a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        23  0x101331f65 testing::UnitTest::Run()
        24  0x1012a8431 RUN_ALL_TESTS()
        25  0x1012a83c6 TestWebKitAPI::TestsController::run(int, char**)
        26  0x101275277 main
        27  0x7ff805aec310 start
Comment 2 Radar WebKit Bug Importer 2023-03-15 15:02:57 PDT 
<rdar://problem/106775188>
Comment 3 Bri Harris 2023-03-15 15:44:19 PDT 
I was able to reproduce this crash at Ventura ToT as follows:

run-api-tests --no-build TestWGSL.WGSLASTDumperTests.dumpTriangleVert --debug --verbose


I was able to verify regression by running this test at 261690@main with the test crashing. This crash was not reproduced on 261689@main or 261686@main or prior.
Comment 4 Alexey Proskuryakov 2023-03-16 09:13:59 PDT 
The culprit was reverted in https://commits.webkit.org/261722@main