Bug 253992

Summary:	New argument in run_benchmark's BrowserDriver init broke linux platform subclass
Product:	WebKit	Reporter:	valerie young <spectranaut>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	clopez, emw, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=253553

Description valerie young 2023-03-15 17:03:52 PDT

Introduced by: https://github.com/WebKit/WebKit/commit/fa4a5245bfbbbbd12c6fd9fea70b4efc83f2023a

The fix is simple, we just need to expect that argument in the init here: https://github.com/WebKit/WebKit/blob/a48e91ce4ab51138a9c6f01a2289c5429f11be21/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py#L48

I'll submit a fix right now.

Comment 1 valerie young 2023-03-15 17:16:10 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11581

Comment 2 EWS 2023-03-15 17:44:49 PDT

Committed 261723@main (9179a6c1494d): <https://commits.webkit.org/261723@main>

Reviewed commits have been landed. Closing PR #11581 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-03-15 17:45:17 PDT

<rdar://problem/106782597>

Comment 4 Elliott Williams 2023-03-15 18:41:06 PDT

Thank you and sorry for the disruption!