Bug 254000
| Summary: | In results.html, match-ref test links to expected images have an extra dot between the filename and the extension | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | Tools / Tests | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Gerald Squelart
The problem is visible in rdar://100336472 , where the results page shows "ref mismatch" but the URL contains an extra dot: `[...]attachment-wrapping-action-expected-mismatch..html`, making it impossible to view the image.
The code in results.html's imageResultLinks looks like:
> let testExtension = Utils.splitExtension(testResult.name)[1];
...
> result += TestResultsController.resultLink(this._resultsController.layoutTestsBasePath() + testPrefix, '-expected-mismatch.' + testExtension, 'ref mismatch');
...
> result += TestResultsController.resultLink(this._resultsController.layoutTestsBasePath() + testPrefix, '-expected.' + testExtension, 'reference');
The `testExtension` variable contains ".html", so we don't need to add one before.
<rdar://106785429>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/11589
EWS
Committed 261791@main (9872023d5aed): <https://commits.webkit.org/261791@main>
Reviewed commits have been landed. Closing PR #11589 and removing active labels.