Bug 254052

Summary:	[git-webkit] Handle ssh protocol with user
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Jonathan Bedard

Reported 2023-03-16 16:21:48 PDT

The ssh protocol for git checkouts may define both the user and the protocol. Handle this case in our pre-push regex, and write a unit test for our regex so we can ennumerate any future configurations contributors stumble into.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-03-16 16:22:00 PDT

<rdar://problem/106832995>

Jonathan Bedard

Comment 2 2023-03-16 16:28:14 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11629

EWS

Comment 3 2023-03-17 09:02:57 PDT

Committed 261795@main (bb518ed01306): <https://commits.webkit.org/261795@main> Reviewed commits have been landed. Closing PR #11629 and removing active labels.

EWS

Comment 4 2023-03-20 12:06:08 PDT

Committed 259548.448@safari-7615-branch (5f13122febab): <https://commits.webkit.org/259548.448@safari-7615-branch> Reviewed commits have been landed. Closing PR #480 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.