| Summary: | Can't activate feature with all caps tag via font-feature-settings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | elaine | ||||||
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | graouts, mmaxfield, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
elaine
2023-03-19 22:56:07 PDT
Created attachment 465514 [details]
Test case
I can reproduce with ToT. Looks like the font we're creating doesn't actually have the XPOS feature set 🤔 Looks like we're lowercasing XPOS -> xpos auto tag = consumeFontTag<FontTagCaseManipulation::ToASCIILower>(range); 🤔 http://w3c.github.io/csswg-drafts/css-fonts-4/#font-feature-settings-prop > The <string> is a case-sensitive OpenType feature tag. The included font claims to be in the public domain, so I can just make a layout test with it. Pull request: https://github.com/WebKit/WebKit/pull/11739 Committed 262463@main (6e7c8de0a165): <https://commits.webkit.org/262463@main> Reviewed commits have been landed. Closing PR #11739 and removing active labels. |