| Summary: | [IFC][Partial layout] Fix http/tests/security/cross-origin-cached-images-with-memory-pressure.html | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2023-03-20 06:52:03 PDT
Created attachment 465518 [details]
Patch
Comment on attachment 465518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465518&action=review > Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:318 > + if (m_inlineItems.isEmpty()) { > + // We must be under memory pressure. > + updateInlineDamage(InlineDamage::Type::Invalid, { }); > + return; > + } Maybe these could be factored into a function if (!canUsePartialInvalidation()) return; if (setFullDamageIfNeeded())
return;
or something.
(In reply to Antti Koivisto from comment #3) > if (setFullDamageIfNeeded()) > return; > > or something. good idea! Will do. Created attachment 465520 [details]
Patch
Committed 261892@main (01f5eadff3e2): <https://commits.webkit.org/261892@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465520 [details]. |