Bug 254161

Summary:	[pre-push] Handle 'None' commits
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Jonathan Bedard 2023-03-20 09:55:16 PDT

`subprocess.run` does not handle 'None' arguments, so all of our '_for(commit)' functions in our pre-push hooks should return None if the commit argument provided is None.

Comment 1 Radar WebKit Bug Importer 2023-03-20 09:55:30 PDT

<rdar://problem/106949161>

Comment 2 Jonathan Bedard 2023-03-20 09:58:30 PDT

Pull request: https://github.com/WebKit/WebKit/pull/11714

Comment 3 EWS 2023-03-20 11:31:24 PDT

Committed 261884@main (98754beb9912): <https://commits.webkit.org/261884@main>

Reviewed commits have been landed. Closing PR #11714 and removing active labels.

Comment 4 EWS 2023-03-20 13:32:27 PDT

Committed 259548.450@safari-7615-branch (79f3c6391fc2): <https://commits.webkit.org/259548.450@safari-7615-branch>

Reviewed commits have been landed. Closing PR #482 and removing active labels.