| Summary: | [image-set] Handle zero resolution and clamping negative resolutions in calc expressions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Ryan Reno <rreno> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rreno, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://wpt.fyi/results/css/css-images/image-set/image-set-negative-resolution-rendering-2.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=256367 | ||
|
Description
Tim Nguyen (:ntim)
2023-03-23 19:43:28 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11906 I took care of the WPT, morphing this to be about zero resolutions Pull request: https://github.com/WebKit/WebKit/pull/13479 I figured out how to get clamping to work it was really easy. Just had to pass ValueType::NonNegative to consumeMetaConsumer to get forwarded into the calc function parser. Updated the PR. correction: ValueRange::NonNegative Committed 264298@main (f9cc497c0b28): <https://commits.webkit.org/264298@main> Reviewed commits have been landed. Closing PR #13479 and removing active labels. *** Bug 256367 has been marked as a duplicate of this bug. *** |