Bug 254441

Summary: JSRopeString::resolveRopeToAtomString() doesn't need to copy characters to a buffer when it is a substring
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: JavaScriptCoreAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 254474    
Bug Blocks:    

Chris Dumez
Reported 2023-03-24 12:35:57 PDT
JSRopeString::resolveRopeToAtomString() doesn't need to copy characters to a buffer when it is a substring, we can construct the AtomString straight from the StringView::substring() output.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-03-24 12:37:36 PDT
Pull request: https://github.com/WebKit/WebKit/pull/11946
EWS
Comment 2 2023-03-24 15:39:18 PDT
Committed 262103@main (3bc3bb7a66f1): <https://commits.webkit.org/262103@main> Reviewed commits have been landed. Closing PR #11946 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-03-24 15:40:22 PDT
<rdar://problem/107205966>
Note You need to log in before you can comment on or make changes to this bug.