| Summary: | AX: Only FRED VP visible on the Text To Speech Sound Check page | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||||||
| Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | andresg_22, tyler_w, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
chris fleizach
2023-03-24 12:52:39 PDT
Created attachment 465575 [details]
Patch
Created attachment 465576 [details]
Patch
Created attachment 465577 [details]
Patch
Comment on attachment 465577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465577&action=review > COMMIT_MESSAGE:2 > +https://bugs.webkit.org/show_bug.cgi?id=254443 I think you need a Radar link below your Bugzilla URL. If you re-run `git-webkit setup` this should start appearing in your commit message template. > LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html:9 > + description("This tests that we can get Samantha."); Can probably move everything inside this script tag back one indentation level. > LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html:12 > + var speech = window.speechSynthesis; > + var list = speech.getVoices(); Seems like we only use this `var speech` in one place. Might make the test a bit more clean to directly use window.speechSynthesis to `getVoices()`. > LayoutTests/fast/speechsynthesis/mac/samantha-voice-available.html:22 > + This newline seems unnecessary. Created attachment 465578 [details]
Patch
Committed 262117@main (f20573ec09c6): <https://commits.webkit.org/262117@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465578 [details]. |