Bug 254474

Summary: Regression(262103@main) JSRopeString::resolveRopeToAtomString() no longer reports extra memory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: JavaScriptCoreAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 254441    

Chris Dumez
Reported 2023-03-25 19:34:59 PDT
JSRopeString::resolveRopeToAtomString() no longer reports extra memory since 262103@main. Because we're holding the resolved rope as an AtomString, `valueInternal().impl()->hasOneRef()` could never be true.
Attachments
Chris Dumez
Comment 1 2023-03-25 19:36:27 PDT
EWS
Comment 2 2023-03-27 10:31:55 PDT
Committed 262158@main (0a0fdf90f82f): <https://commits.webkit.org/262158@main> Reviewed commits have been landed. Closing PR #11977 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-03-27 10:32:24 PDT
Note You need to log in before you can comment on or make changes to this bug.