| Summary: | [GLib] Build system does not gracefully fallback to libelogind | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | apteryx <maxim.cournoyer> |
| Component: | CMake | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
I meant:
pkg_check_modules(PC_SYSTEMD QUIET libsystemd)
if (NOT PC_SYSTEMD_FOUND)
pkg_check_modules(PC_SYSTEMD QUIET libelogind)
endif()
Pull request: https://github.com/WebKit/WebKit/pull/11989 Committed 262163@main (f2566d6ee880): <https://commits.webkit.org/262163@main> Reviewed commits have been landed. Closing PR #11989 and removing active labels. |
Hello, When using elogind instead of systemd, the build fails because FindJournald.cmake looks for pkg_check_modules(PC_SYSTEMD QUIET libsystemd) but the pkg-config file of elogind is called libelogind.pc. There should be a fallback implemented like so: pkg_check_modules(PC_SYSTEMD QUIET libsystemd libelogind) if (NOT PC_SYSTEMD_FOUND) pkg_check_modules(PC_SYSTEMD QUIET libelogind) endif() I'll send a patch if I remember the process :-). Thank you!