| Summary: | [IFC] Incorrect out-of-flow box placement when text-indent is present (display: inline) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, twisniewski, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2023-03-26 17:30:25 PDT
Created attachment 465599 [details]
Patch
Created attachment 465613 [details]
[fast-cq]Patch
Committed 262170@main (fd637abec439): <https://commits.webkit.org/262170@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465613 [details]. zalan, the test-case in the commit here renders quite differently in Firefox and Chrome, and not at all like the expected.html. Is this expected? (In reply to Thomas Wisniewski [:twisniewski] from comment #5) > zalan, the test-case in the commit here renders quite differently in Firefox > and Chrome, and not at all like the expected.html. Is this expected? Here I was just matching the new inline layout codepath (IFC) with our legacy behavior (in retrospect, I should have named the files accordingly). Ah, I see, s Chrome and Firefox's behavior is still considered correct, and Safari is considered to be failing this test? Thanks for the clarification! (In reply to Thomas Wisniewski [:twisniewski] from comment #7) > Ah, I see, s Chrome and Firefox's behavior is still considered correct, and > Safari is considered to be failing this test? I didn't look too closely. Let me look at these tests again. (In reply to zalan from comment #8) > (In reply to Thomas Wisniewski [:twisniewski] from comment #7) > > Ah, I see, s Chrome and Firefox's behavior is still considered correct, and > > Safari is considered to be failing this test? > I didn't look too closely. Let me look at these tests again. Apparently all the block containers have "text-indent: each line" which, according to caniuse, FireFox does not support yet. No wonder rendering does not match. (this is about testing out-of-flow static positioning with the origin display value of "inline" after the _last_ line with _text_indent_) Ah, you're right, that certainly does explain why the rendering would be different in Chrome and Firefox. Maybe it's a good time to port these tests over to web platform tests, to further encourage other vendors to finish their implementations as well.. |