Bug 254562

Summary:	WebKit needs to pass along NotificationOptions.silent to API clients
Product:	WebKit	Reporter:	lehu <hi>
Component:	Platform	Assignee:	Brady Eidson <beidson>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	beidson, pwadeveloper2, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari 16
Hardware:	All
OS:	All
See Also:	https://bugs.webkit.org/show_bug.cgi?id=254969

Description lehu 2023-03-27 18:50:18 PDT

Notification pushed by WebPush does not play alert sound both on iOS and macOS.

And here is a demo to reoccur this issue.

https://bugs.webkit.org/show_bug.cgi?id=252544#c3

Comment 1 Radar WebKit Bug Importer 2023-03-30 09:29:29 PDT

<rdar://problem/107424158>

Comment 2 Brady Eidson 2023-04-19 19:49:41 PDT


WebKit itself does not display notifications, and cannot affect whether or not sound plays.

But for clients to be able to make the "sound or silent?" decision, WebKit needs to pass along the silent flag from NotificationOptions.

Let's do that here. Retitling to:
WebKit needs to pass along NotificationOptions.silent to API clients

Comment 3 Brady Eidson 2023-04-19 19:59:19 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12953

Comment 4 EWS 2023-04-20 11:38:40 PDT

Committed 263184@main (c33fee9a5907): <https://commits.webkit.org/263184@main>

Reviewed commits have been landed. Closing PR #12953 and removing active labels.