Bug 254596

Summary:	REGRESSION (262146@main): TestWGSL.WGSLASTDumperTests.dumpTriangleVert is failing
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	New Bugs	Assignee:	Tadeu Zagallo <tzagallo>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mmaxfield, tzagallo, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=254421

Description Ryan Haddad 2023-03-28 09:30:21 PDT

The following test is failing on iOS and macOS queues after https://commits.webkit.org/262146@main

    TestWGSL.WGSLASTDumperTests.dumpTriangleVert
        
        /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Tools/TestWebKitAPI/Tests/WGSL/ASTStringDumperTests.cpp:71
        Expected equality of these values:
          toString(shader)
            Which is: 8-byte object <C0-00 03-0F 01-00 00-00>
          "@vertex\n" "fn main(\n" "    @builtin(vertex_index) VertexIndex: u32\n" ") -> @builtin(position) Vec4<f32>\n" "{\n" "    var pos = array<Vec2<f32>, 3>(Vec2<f32>(0.000000, 0.500000), Vec2<f32>(-0.500000, -0.500000), Vec2<f32>(0.500000, -0.500000));\n" "    return Vec4<f32>(pos[VertexIndex], 0.000000, 1.000000);\n" "}\n\n\n"_str
            Which is: 8-byte object <60-49 00-0F 01-00 00-00>

https://results.webkit.org/?suite=api-tests&test=TestWGSL.WGSLASTDumperTests.dumpTriangleVert

Comment 1 Radar WebKit Bug Importer 2023-03-28 09:30:47 PDT

<rdar://problem/107320480>

Comment 2 Tadeu Zagallo 2023-03-28 10:06:48 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12059

Comment 3 EWS 2023-03-28 10:09:25 PDT

Committed 262226@main (d9f105bb73af): <https://commits.webkit.org/262226@main>

Reviewed commits have been landed. Closing PR #12059 and removing active labels.