Bug 254627

Summary: [git-webkit] Prevent publication of commits for redacted PRs
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=255043

Description Jonathan Bedard 2023-03-28 16:36:36 PDT 
By design, git-webkit makes it very hard to opt-in to publishing a fix for a redacted PR. The recent addition of a pre-push hook makes this less crucial, because regardless of how a user answers prompts by `git-webkit`, any push containing a redacted issue will prompt the user before contacting the server. `git-webkit` should respect a user when they explicitly request to make a fix for a redacted issue public.
Comment 1 Radar WebKit Bug Importer 2023-03-28 17:18:00 PDT 
<rdar://problem/107343169>
Comment 2 Jonathan Bedard 2023-03-29 07:01:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/12110
Comment 3 Jonathan Bedard 2023-04-05 11:39:52 PDT 
After talking with Geoff and landing https://commits.webkit.org/262617@main, we're basically going to do the exact opposite of this: we're going to forbid publication of commits for redacted PRs in all circumstances. I'm going to re-purpose this bug because anyone following it already will care about us doing the inverse.
Comment 4 EWS 2023-04-18 15:36:44 PDT 
Committed 263101@main (9384f300d865): <https://commits.webkit.org/263101@main>

Reviewed commits have been landed. Closing PR #12110 and removing active labels.